Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: examples #2920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: examples #2920

wants to merge 1 commit into from

Conversation

kariya-mitsuru
Copy link
Contributor

Description

serviceSubnet "10.70.0.0/12" and "10.90.0.0/12" are invalid.

@adamjensenbot
Copy link
Collaborator

Hi @kariya-mitsuru. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Feb 6, 2025
cheina97
cheina97 requested changes Feb 11, 2025
View reviewed changes
examples/stateful-applications/manifests/cluster1.yaml
@@ -1,7 +1,7 @@
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
networking:
serviceSubnet: "10.90.0.0/12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the same CIDR and use 10.80.0.0/12 ? Thanks in advice

examples/stateful-applications/manifests/cluster2.yaml
@@ -1,7 +1,7 @@
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
networking:
serviceSubnet: "10.70.0.0/12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@kariya-mitsuru
fix: examples
4ad4bed 
serviceSubnet "10.70.0.0/12" and "10.90.0.0/12" are invalid.

Signed-off-by: Mitsuru Kariya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
fix Fixes a bug in the codebase. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kariya-mitsuru @adamjensenbot @cheina97